Put close icons at the start of the tab label by default on macOS #15103
+53
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdamus
force-pushed
the
issues/theia-ide/460
branch
from
32cc3de to
69af7eb
Compare
msujew
reviewed
Mar 3, 2025
packages/core/i18n/nls.json
Outdated
Comment on lines
457
to
463
| "window": { | ||
| "tabCloseIconPlacement": { | ||
| "description": "Place the close icons on tab titles at the start or end of the tab. The default is the host OS convention.", | ||
| "end": "Place the close icon at the end of the label. In left-to-right languages, this is the right side of the tab.", | ||
| "start": "Place the close icon at the start of the label. In left-to-right languages, this is the left side of the tab." | ||
| } | ||
| } |
There was a problem hiding this comment.
Please don't add the translations manually to the nls.json file. We have a workflow for that that automatically performs this task before the release. See also here.
There was a problem hiding this comment.
Thanks, Mark! I'll revert that.
There was a problem hiding this comment.
Reverted with commit f61560f. Perhaps that linked documentation can add a note that these files are not meant to be edited by hand when adding new translatable strings.
Add a new window.tabCloseIconPlacement preference for whether to present the Close (X) icon in tab titles on the left or the right of the tab. Default to the left on macOS platform in conformity with the OS's native tab controls. Show the new preference in the Settings UI on macOS platform only. Render the tab title with the icon on the left or right accordingly. Fixes eclipse-theia/theia-ide#460 Signed-off-by: Christian W. Damus <[email protected]>
Per review, don't attempt to manually add strings to the nls bundle. Signed-off-by: Christian W. Damus <[email protected]>
cdamus
force-pushed
the
issues/theia-ide/460
branch
from
69af7eb to
f61560f
Compare
|
I'm trying to figure out what the test failure is in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds a new
window.tabCloseIconPlacementpreference for whether to present the Close (X) icon in tab titles on the left or the right of the tab.Defaults to the left on macOS platform in conformity with the OS's native tab controls.
The tab bar rendering is updated to take the preference into account.
The preference is suppressed in the Settings view on non-Mac platforms as being largely irrelevant on those systems.
Fixes eclipse-theia/theia-ide#460
How to test
On a macOS system, build and launch the Theia example app. See that tabs in the main editor area are on the left side where they belong.
Open Settings and change the "Tab close icon placement" preference to "end". See the close icons move back to where they are presented on Linux and Windows platforms. Restore the default setting. See the close icons restored to the left side.
On Linux and Windows systems, verify that the "Tab close icon placement" preference does not appear in the Settings UI and that tab titles look as they ever did.
Follow-ups
None.
Breaking changes
Attribution
None.
Review checklist
Note
My testing is only on macOS platform as that is the platform that my system runs and the feature is meant to be disabled on other platforms. I'm depending on buddy tests from the Theia community to check for regressions on other platforms.
Reminder for reviewers