Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build image reference from release workflow, consolidate go setup in GitHub actions #8158

Closed

Conversation

bryantbiggs
Copy link
Member

Description

  • Remove container: public.ecr.aws/eksctl/eksctl-build:... references; this image is no longer used and does not appear to have any bearing on the CI release process - the artifacts will be build directly in the GitHub runner environment
  • Consolidate the misc actions/cache actions for caching go depdencies - this is already handled by the internal .github/actions/setup-build action
  • Consolidate the misc actions/setup-go actions for installing go - this is already handled by the internal .github/actions/setup-build action which means less places to remember to update the go version in the future
  • Remove the secrets.EKSCTLBOT_TOKEN usage from actions/checkout - this should be necessary given that the code is publicly available

⚠️ this can only proceed once the changes in #8157 are added back to main

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@bryantbiggs bryantbiggs added kind/bug skip-release-notes Causes PR not to show in release notes labels Jan 22, 2025
@bryantbiggs bryantbiggs closed this Feb 6, 2025
@bryantbiggs bryantbiggs deleted the fix/remove-build-image branch February 6, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant