Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile #151

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix Dockerfile #151

merged 1 commit into from
Jan 10, 2025

Conversation

StefMa
Copy link
Contributor

@StefMa StefMa commented Jan 10, 2025

If I build with docker like

docker build -t bore  .                                                                                                                             

it reports an error:

1 warning found (use docker --debug to expand):

  • FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)

Seems as should be in uppercase (or both in lowecase) 🙃
See also https://docs.docker.com/reference/build-checks/from-as-casing/

@sagar676
Copy link

is bore.pub giving timeout?

@StefMa
Copy link
Contributor Author

StefMa commented Jan 10, 2025

I don't know 🤷‍♂️ but this change hasn't anything to do with the problem mentioned in #150

@ekzhang
Copy link
Owner

ekzhang commented Jan 10, 2025

Thanks! I'm glad they're clamping down on casing, haha. Have been doing FROM image:tag as name for so long that I thought that was actually the official syntax.

@ekzhang ekzhang merged commit b23beb9 into ekzhang:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants