Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add Elastic Agent collection #15528

Merged
merged 23 commits into from
Nov 14, 2023
Merged

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Nov 3, 2023

Related: https://github.com/elastic/ingest-dev/issues/2462
Related: #15439
Based on : #15508

This work starts with all the goodness in #15508 from @robbavey, removes extra heading levels for easier parsing, smooths flow, and ideally, sets us up for easier maintenance going forward.

PREVIEW: https://logstash_15528.docs-preview.app.elstc.co/guide/en/logstash/master/monitoring-with-ea.html

Comment on lines 72 to 104
=== Confirm Enrollment
// Include section about confirming enrollment
include::monitoring-confirm.asciidoc[tag=confirm-enrollment-widget]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading is "Confirm Enrollment," but the section leads off with "After enrollment is confirmed..." This makes me think that "Confirm Enrollment" should be part of the previous section, and that we need a more appropriate name for what's going on in this section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense - I think confirming enrollment is just the resolution of "installing agents"

Comment on lines 70 to 112
// Include section about confirming enrollment
include::monitoring-confirm.asciidoc[tag=confirm-enrollment-widget]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading is "Confirm Enrollment," but the section leads off with "After enrollment is confirmed..." This makes me think that "Confirm Enrollment" should be part of the previous section, and that we need a more appropriate name for what's going on in this section.

include::monitoring-mb.asciidoc[tag=define-cluster-uuid]

[discrete]
[[set-up-monitoring]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving this to the stack monitoring section, instead of having this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Working on a better approach.

[[create-user]]
=== Create a monitoring user (stack monitoring only)

Create a user on the production cluster that has the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to do this for standalone agent too - what do you think about adding this to the stack monitoring section, and the standalone agent tab?

Or, even adding a tabbed section here for Stack Monitoring, Standalone Agent and Fleet managed?

@@ -1,6 +1,6 @@
[role="xpack"]
[[configuring-logstash]]
== Monitoring {ls}
== Monitoring {ls} (legacy)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to figure out if we want to call this "legacy" yet, while dashboards are still in beta

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user was implementing monitoring from the ground up, we'd likely encourage them to go with agent. Maybe we can add a note in the MB section saying it's still a viable option, but they might want to consider one of the new approaches instead? Let's get Trevor's input.

Comment on lines 72 to 104
=== Confirm Enrollment
// Include section about confirming enrollment
include::monitoring-confirm.asciidoc[tag=confirm-enrollment-widget]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense - I think confirming enrollment is just the resolution of "installing agents"


You can use {agent} to collect monitoring data for:

- dashboard. <Brief description with link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- dashboard. <Brief description with link>
- {ls} Dashboards. <Brief description with link>

You can use {agent} to collect monitoring data for:

- dashboard. <Brief description with link>
- stack. <Brief description with link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- stack. <Brief description with link>
- Legacy Stack Monitoring UI. <Brief description with link>

I'm not sure how best to distinguish between the two - I think "Legacy Stack Monitoring UI" might work

When you've completed the prerequisites, you're ready to install and configure {agent} for your monitoring use case.

- dashboard. <Brief description with link>
- stack. <Brief description with link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as earlier on how we reference each of these UIs

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great - I like the changes and the organization that you've put in here


Install and configure {agent} to collect {ls} monitoring data for dashboards.
We'll walk you through the process in these steps:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a link to the general agent installation page somewhere, for more details than we will give here? I'm not sure if this is the right place, but it might work here, or at the bottom of this section?

--
[role="screenshot"]
image::images/kibana-home.png[{kib} home page]
--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about having a widget in a follow-up PR that shows the serverless flow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the "follow-up PR" idea, but I have a different approach I'll run by you.


Prerequisites:
[[create-user-ea]]
.Create a monitoring user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Create a monitoring user
.Create a monitoring user (standalone agent only)

We don't need to create a monitoring user if the user is using fleet here

[[view-assets-ead]]
=== View assets
// Include section about viewing assets
include::monitoring-confirm.asciidoc[tag=confirm-enrollment-widget]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about splitting this content into logs and metrics - Logs dashboards are common to both, and could be a shared doc.

While, sadly, both sets of assets are installed regardless of which metric collection method is used, they only have relevance in the Dashboards.

I was wondering if we should have a an explanatory section for Dashboards, which explains what each of the dashboards are (or at least an inventory), and one for Stack Monitoring, which says that these dashboards are not populated when dashboard collection is disabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely worth exploring in a follow-up PR.

@karenzone karenzone marked this pull request as ready for review November 13, 2023 23:34
@robbavey
Copy link
Member

@karenzone I updated the screenshots, removing those that weren't used, and fixed up the differences between the fleet managed and standalone screenshots

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as a first pass - I think we can add extra information on the dashboard contents, and I'd like to add a section on how to install on serverless, but this LGTM

@robbavey robbavey force-pushed the 2462-agent-monitoring branch from d262339 to 179d5f3 Compare November 14, 2023 18:25
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @robbavey @karenzone

@karenzone karenzone merged commit c060c00 into elastic:main Nov 14, 2023
@karenzone karenzone deleted the 2462-agent-monitoring branch November 14, 2023 18:55
@karenzone
Copy link
Contributor Author

#48869

@karenzone
Copy link
Contributor Author

@logstashmachine backport 8.11

github-actions bot pushed a commit that referenced this pull request Nov 14, 2023
Co-authored-by: Rob Bavey <[email protected]>
(cherry picked from commit c060c00)
karenzone added a commit that referenced this pull request Nov 15, 2023
Co-authored-by: Rob Bavey <[email protected]>
(cherry picked from commit c060c00)

Co-authored-by: Karen Metts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants