Add some initial binary queue samples #9570
Conversation
andrewvc
changed the title
|
@original-brownbear @danhermann thoughts on this? |
|
Ideally, these samples would include an exhaustive set of types that can be serialized. It would also be nice if the test could verify that all possible types were present in a particular sample by checking against the list of available converters here: That's still a little tricky since there's a fall-through converter that attempts to convert based on the assignability of a class to anything in the above list. I don't know if these test criteria are overly ambitious for right now, but it's definitely something I intend to do for PQv2. |
| * @param omitParentDir omit the parent dir the zip is packaged with | ||
| * @throws IOException | ||
| */ | ||
| public static void unzipToDirectory(final ZipInputStream input, final Path output, boolean omitParentDir) throws IOException { |
There was a problem hiding this comment.
Minor -- I prefer putting code that's used only in tests somewhere in the test source tree.
|
@andrewvc @danhermann as far as I can see we have all the types in here with the exception of |
|
What about nil, symbols, floats? And I like the test, too. I just think it would be ideal if the test itself verified that it was testing all possible types though, as I said, that may not be necessary at this point. |
|
Right and those :) |
|
@danhermann @original-brownbear thanks for the feedback. I'll incorporate it. I should have had the config reviewed before generating samples. |
|
@andrewvc np. Actually, before you waste your time regenerating all the samples one thought: Do we even need to generate anything but data for |
|
@original-brownbear good point, let's just generate 6.3.0, we don't even promise 6.2.4 compat. |
Tests for old binary queues. Currently only tests 6.3.0.
I think this is ready for review. I think I should remove all the examples from before 6.3.0 since we know they are all problematic. However, I want to get a second opinion before I throw them away. Thoughts?