Always cleanup agents after each test #9603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
reviewed
May 17, 2018
logstash-core/lib/logstash/agent.rb
Outdated
| begin | ||
| raise "fake" | ||
| rescue => e | ||
| CURRENT_INITIALIZED_BACKTRACE.set(e.backtrace); |
There was a problem hiding this comment.
We can get the backtrace and avoid the overhead of raise/rescue with Kernel#caller, which also allows us to skip the current frame which will always be the same:
if (CURRENT.compare_and_set(nil,self))
backtrace = caller(1) # don't include the current frame
CURRENT_INITIALIZED_BACKTRACE.set(backtrace)
else
raise # ...
end| @@ -52,6 +52,17 @@ def puts(payload) | |||
| example.run | |||
| end | |||
| end | |||
|
|
|||
| c.after(:each) do | |||
andrewvc
force-pushed
the
strict-agent-cleanup
branch
from
eeeb434 to
33ac41f
Compare
yaauie
approved these changes
May 17, 2018
|
jenkins, please retest this |
|
jenkins, please retest this. |
|
jenkins, please test this |
|
jenkins, please retest this |
This code enforces a single active Agent at any time. It's not a singleton, since instances can be removed, but only one can be active. I'd say it's a pseudo-singleton. This is here to prevent one agent staying live and leaking its state causing another to fail in a different test. I'm not quite sure *how* this may be causing other tests to break, but it seems like a good sanity check for the time being since we do have some evidence of this. Some tests seem to fail when two agents, that shouldn't share PQs, somehow do. I suspect its a weird race when two agents are active.
andrewvc
force-pushed
the
strict-agent-cleanup
branch
from
33ac41f to
d17c670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code enforces a single active Agent at any time. It's not a singleton, since instances can be removed, but only one can be active.
I'd say it's a pseudo-singleton.
This is here to prevent one agent staying live and leaking its state causing another to fail in a different test.
I'm not quite sure how this may be causing other tests to break, but it seems like a good sanity check for the time being since we do have some evidence of this.
Some tests seem to fail when two agents, that shouldn't share PQs, somehow do. I suspect its a weird race when two agents are active.