-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command for building the artifacts inside Docker #9609
Open
tsg
wants to merge
1
commit into
elastic:main
Choose a base branch
from
tsg:add_docker_build_artifacts_command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#!/bin/bash | ||
|
||
# This should be called from top repository folder. | ||
# It runs the `rake artifact:all` command in a docker image that has the required | ||
# dependencies. | ||
# | ||
# The artifacts will be placed in the build/ folder. | ||
|
||
docker build -f rakelib/Dockerfile.artifacts -t ls-artifacts rakelib/ | ||
docker run --rm \ | ||
-v $(pwd):/logstash:delegated \ | ||
ls-artifacts \ | ||
sh -c "cd logstash && rake artifact:all" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# This image contains the right dependencies to run `rake artifacts:all` | ||
# Example usage: | ||
# | ||
# docker build -f rakelib/Dockerfile.artifacts -t ls-artifacts rakelib/ | ||
# docker run -it --rm -v `pwd`:/logstash:delegated ls-artifacts sh -c "cd logstash && rake artifact:all" | ||
# | ||
# Note that it seems that rake is a particularly bad case scenario for the | ||
# docker osxfs driver (it touches 10s of K of files). Hence the `:delegated` | ||
# parameter above is needed to get things to work at all, but it is still slow | ||
# and it's going to consume a lot of CPU. | ||
# | ||
# See https://docs.docker.com/docker-for-mac/osxfs/#performance-issues-solutions-and-roadmap | ||
FROM jruby:9 | ||
|
||
RUN \ | ||
apt-get update && \ | ||
apt-get install -y --no-install-recommends \ | ||
default-jdk git binutils rpm |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason this breaks on docker is that we don't have a gradle task for it. If we had
./gradlew artifactAll
invoke the rake task it would probably not segfault. Here's an example gradle task that invokes rakehttps://github.com/elastic/logstash/blob/master/build.gradle#L176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that does the trick, I'll update the PR.