-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PQ Docs: add note about upgrading #9762
base: main
Are you sure you want to change the base?
Conversation
Notes:
|
@yaauie WRT "Notes"
Currently the text you're referencing is only in 6.2 and 6.3, so the link will work only for those versions. We've just recently decided to add it to 6.x, but as of this moment, I haven't added it. Having older versions point to 6.3 feels wrong, but this is a crazy situation and might make sense. |
I was concerned about having outdated info saying that you could upgrade with PQ running, even for older versions. I'm in the process of back-porting content. When done, I'll test your link. |
with each release of Logstash; using the latest available version of Logstash | ||
will ensure you're using the best available version of this and other features. | ||
To enable the smoothest transition when upgrading, especially from versions | ||
prior to 6.3.0, you're encouraged to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's going to be very weird to mention 6.3.0 in releases that occurred prior to 6.3.0. I would remove the mention of 6.3.0 from the note all together and make sure the note shows up in all relevant versions (where the queue.drain option exists) up to, but not including, the version where draining the queue is no longer required.
Please pardon my delay in getting back to you. I had to add new content for you to link to, and make sure that the wording made sense in context of each version.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For later versions, we removed the recommendation to drain the queue before upgrade. amd 6.x is no longer supported. We can close this.
Since the PQ was released as GA in 5.4, to ensure that the note shows up on generated docs pages, this note on upgrading should be back-ported to every major/minor branch since:
6.x
,6.3
,6.2
,6.1
,6.0
,5.6
,5.5
, and5.4