Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add template project link for ElectronJS application using NextJS and TypeScript #8844

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

saulotarsobc
Copy link

@saulotarsobc saulotarsobc commented Feb 4, 2025

ElectronJS application with NextJS and TypeScript.

demo

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 1948b71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saulotarsobc saulotarsobc changed the title Update README.md feat: ElectronJS application with NextJS and TypeScript Feb 4, 2025
@mmaietta mmaietta changed the title feat: ElectronJS application with NextJS and TypeScript chore(docs): add template project link for ElectronJS application using NextJS and TypeScript Feb 5, 2025
@mmaietta
Copy link
Collaborator

mmaietta commented Feb 5, 2025

Any chance you could put together a more simple repo? Something I can reasonably read through? And preferably without binary files like .mp4...

Not trying to be offensive, I'm just being cautious of adding a project with only 19 stars to be advertised in this project w/ 1+ mil downloads/month.

@saulotarsobc
Copy link
Author

@mmaietta ok. thanks for the suggestions. I will make the adjustments.

@saulotarsobc
Copy link
Author

saulotarsobc commented Feb 6, 2025

Hello my friend. I think I managed to apply your suggestions. Can you check again, please?

@mmaietta

@saulotarsobc
Copy link
Author

@mmaietta I replaced Mantine with Tailwind 4.0 to make the template simpler.

@mmaietta
Copy link
Collaborator

Thanks. There was quite a bit of your code to read through while the CI was running yesterday. I'll need to re-review the template repo since things were changed

@saulotarsobc
Copy link
Author

saulotarsobc commented Feb 19, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants