Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to scroll-to-top by clicking header title in account, list, and tag pages #2635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 28, 2024

In Elk, we can click the title to scroll to the top pages. This is useful after reading many posts. But some pages don't have this feature and the title text style was inconsistent.

This RP ensures that three pages (user account, list, tag) have this feature. All of them usually have many posts so the scroll-to-top feature should be useful too.

User account page

https://deploy-preview-2635--elk-zone.netlify.app/universeodon.com/@elkdev
(note: title is not shown in wider screen size)

Before

Screenshot from 2024-02-28 23-13-52

After

Screenshot from 2024-02-28 23-13-28

List page

https://deploy-preview-2635--elk-zone.netlify.app/universeodon.com/list/2769

Before

Screenshot from 2024-02-28 23-14-58

After

Screenshot from 2024-02-28 23-14-46

Hashtag page

https://deploy-preview-2635--elk-zone.netlify.app/tags/elk

Before

Screenshot from 2024-02-28 23-14-19

After

Screenshot from 2024-02-28 23-14-30

Copy link

stackblitz bot commented Feb 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 9d405ed
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65df42e91a25f6000837b02d

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 9d405ed
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65df42e920c8b00008ba3c0d
😎 Deploy Preview https://deploy-preview-2635--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@patak-dev
Copy link
Member

I think this is a good change, but we should first fix an issue with the back arrow as it will happen after this PR in more cases. The back arrow should only be there if there is history inside the page to navigate, if not we shouldn't show it. For example, I think the arrow shouldn't appear if I visit this link: https://deploy-preview-2635--elk-zone.netlify.app/universeodon.com/@elkdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants