Add disk io stats to EWW_DISK #1267
Open
+62
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-lfchen
suggested changes
Jan 13, 2025
| components | ||
| .iter() | ||
| .map(|c| { | ||
| ( | ||
| c.label().to_uppercase().replace(' ', "_"), | ||
| // It is common for temperatures to report a non-numeric value. | ||
| // Tolerate it by serializing it as the string "null" | ||
| c.temperature().to_string().replace("NaN", "\"null\""), | ||
| c.temperature().unwrap_or(NAN).to_string().replace("NaN", "\"null\""), |
There was a problem hiding this comment.
this should leverage the power of the type system.
consider this, from #1217:
Suggested change
| c.temperature().unwrap_or(NAN).to_string().replace("NaN", "\"null\""), | |
| c.temperature().map_or_else(|| String::from("\"null\""), |temp| temp.to_string()), |
| "read": usage.read_bytes as f64 / elapsed.as_secs_f64(), | ||
| "written": usage.written_bytes as f64 / elapsed.as_secs_f64(), |
There was a problem hiding this comment.
it might be unclear which unit this is. consider documenting it
Comment on lines
30
to
31
| let (ref mut last_refresh, ref mut disks) = &mut *DISKS.lock().unwrap(); | ||
| disks.refresh_specifics(true, DiskRefreshKind::everything()); |
There was a problem hiding this comment.
cleanup, nothing big
Suggested change
| let (ref mut last_refresh, ref mut disks) = &mut *DISKS.lock().unwrap(); | |
| disks.refresh_specifics(true, DiskRefreshKind::everything()); | |
| let (ref mut last_refresh, ref mut disks) = *DISKS.lock().unwrap(); | |
| disks.refresh(true); |
bkueng
force-pushed
the
extend_eew_disk
branch
from
ea6f45b to
d5b1e67
Compare
|
Thanks for the review, I addressed your comments. |
w-lfchen
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very cool project.
Description
This updates system_stats and exposes
readandwrittentoEWW_DISK, allowing to monitor disk io stats.Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing