fix: Prevent default theme from overriding custom themes #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the default theme (
elysiajsTheme
) would override custom themes whenconfig.customCss
was not explicitly set to truly.Before
The default theme was applied whenever
config.customCss
was falsy (null
,undefined
, orfalse
):After
Now, the default theme is only applied if both
config.customCss
andconfig.theme
are falsy:Why?
This prevents the default theme from overriding a manually selected theme when
config.customCss
is falsy butconfig.theme
is set.