Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent default theme from overriding custom themes #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ralex91
Copy link

@Ralex91 Ralex91 commented Feb 16, 2025

This PR fixes an issue where the default theme (elysiajsTheme) would override custom themes when config.customCss was not explicitly set to truly.

Before

The default theme was applied whenever config.customCss was falsy (null, undefined, or false):

<style>
  ${config.customCss ?? elysiajsTheme}
</style>

After

Now, the default theme is only applied if both config.customCss and config.theme are falsy:

<style>
  ${config.customCss || config.theme ? config.customCss : elysiajsTheme}
</style>

Why?

This prevents the default theme from overriding a manually selected theme when config.customCss is falsy but config.theme is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant