Better error messages

embedly · Oct 24, 2017 · 7ba2021 · 7ba2021
1 parent ec20430
commit 7ba2021
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/player.js b/src/player.js
@@ -72,6 +72,12 @@ playerjs.Player.prototype.init = function(elem, options){
 
   this.elem = elem;
 
+  // make sure we have an iframe
+  playerjs.assert(elem.nodeName === 'IFRAME',
+    'playerjs.Player constructor requires an Iframe, got "'+elem.nodeName+'"');
+  playerjs.assert(elem.src,
+    'playerjs.Player constructor requires a Iframe with a \'src\' attribute.');
+
   // Figure out the origin of where we are sending messages.
   this.origin = playerjs.origin(elem.src);
 

diff --git a/test/test.js b/test/test.js
@@ -298,4 +298,4 @@ for (var f in FRAMES){
   } else {
     iframe.onload = loadPlayers;
   }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -298,4 +298,4 @@ for (var f in FRAMES){ @@
       } else {
         iframe.onload = loadPlayers;
       }
-    }
+    }