Make WebIDL binder temp locals threadsafe (#22772)

emscripten-core · Oct 21, 2024 · f88c213 · f88c213
1 parent 8cce4db
commit f88c213
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/tools/webidl_binder.py b/tools/webidl_binder.py
@@ -629,7 +629,8 @@ def make_call_args(i):
     if non_pointer:
       return_prefix += '&'
     if copy:
-      pre += '  static %s temp;\n' % type_to_c(return_type, non_pointing=True)
+      # Avoid sharing this static temp var between threads, which could race.
+      pre += '  static thread_local %s temp;\n' % type_to_c(return_type, non_pointing=True)
       return_prefix += '(temp = '
       return_postfix += ', &temp)'