fix: enable parsing of more bank2ynab files (#202)

envelope-zero · Nov 7, 2023 · d00d1d4 · d00d1d4
1 parent ed7ab0b
commit d00d1d4
Show file tree

Hide file tree

Showing 8 changed files with 93 additions and 147 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -0,0 +1,20 @@
+{
+  "version": "1.0.0",
+  "configurations": [
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "[Jest] ynap-parsers: current file",
+      "program": "${workspaceFolder}/node_modules/.bin/jest",
+      "args": [
+        "${fileBasenameNoExtension}",
+        "--config",
+        "packages/ynap-parsers/jest.config.js"
+      ],
+      "console": "integratedTerminal",
+      "windows": {
+        "program": "${workspaceFolder}/node_modules/jest/bin/jest"
+      }
+    }
+  ]
+}
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/ynap-bank2ynab-converter/package.json b/packages/ynap-bank2ynab-converter/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@envelope-zero/ynap-bank2ynab-converter",
-  "version": "1.14.38",
+  "version": "1.14.39",
   "license": "MIT",
   "author": {
     "email": "[email protected]",

diff --git a/packages/ynap-bank2ynab-converter/src/index.ts b/packages/ynap-bank2ynab-converter/src/index.ts
@@ -23,15 +23,19 @@ program
 
 import { ParserConfig } from './parserconfig';
 
-const CONFIG_URL = `https://raw.githubusercontent.com/bank2ynab/bank2ynab/${program.opts()["branch"]}/bank2ynab.conf`;
+const CONFIG_URL = `https://raw.githubusercontent.com/bank2ynab/bank2ynab/${
+  program.opts()['branch']
+}/bank2ynab.conf`;
 
-const CONFIG_LINK = `https://github.com/bank2ynab/bank2ynab/blob/${program.opts()["branch"]}/bank2ynab.conf`;
+const CONFIG_LINK = `https://github.com/bank2ynab/bank2ynab/blob/${
+  program.opts()['branch']
+}/bank2ynab.conf`;
 
 const SECTION = new RegExp(/^\s*\[([^\]]+)]/);
 const KEY = new RegExp(/\s*(.*?)\s*[=:]\s*(.*)/);
 const COMMENT = new RegExp(/^\s*[;#]/);
 
-const blacklist = program.opts()["exclude"] || [];
+const ignorelist = program.opts()['exclude'] || [];
 
 interface Sections {
   [k: string]: ConfigFields;
@@ -96,14 +100,14 @@ const script = async () => {
 
   const config = parseConfig(configData);
 
-  console.log('Excluding', blacklist.length, 'items from blacklist.');
+  console.log('Excluding', ignorelist.length, 'items from ignorelist.');
 
   const filteredConfig: ParserConfig[] = Object.keys(config)
     .map((c) => ({ ...config[c], Name: c }))
     .filter(
       (c) =>
         c.Name !== 'DEFAULT' &&
-        !blacklist.includes(c.Name) &&
+        !ignorelist.includes(c.Name) &&
         !c.Plugin &&
         c['Source Filename Pattern'] !== 'unknown!' &&
         c['Input Columns'],
@@ -127,7 +131,7 @@ const script = async () => {
             .map((s) => s.trim()),
           headerRows: Number(c['Header Rows'] || '1'),
           footerRows: Number(c['Footer Rows'] || '0'),
-        } as ParserConfig),
+        }) as ParserConfig,
     );
 
   console.log(
@@ -138,8 +142,11 @@ const script = async () => {
     'configs.',
   );
 
-  fs.writeFileSync(program.opts()["output"], JSON.stringify(filteredConfig, null, 2));
-  console.log('Saved configs to', program.opts()["output"].output);
+  fs.writeFileSync(
+    program.opts()['output'],
+    JSON.stringify(filteredConfig, null, 2),
+  );
+  console.log('Saved configs to', program.opts()['output'].output);
 };
 
 script();
diff --git a/packages/ynap-parsers/package.json b/packages/ynap-parsers/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@envelope-zero/ynap-parsers",
-  "version": "1.15.27",
+  "version": "1.15.28",
   "description": "Parsers from various formats to YNAB CSV",
   "main": "index.js",
   "author": "Envelope Zero Team <[email protected]> (https://envelope-zero.org)",
@@ -23,7 +23,6 @@
     "xlsx": "https://cdn.sheetjs.com/xlsx-0.20.0/xlsx-0.20.0.tgz"
   },
   "devDependencies": {
-    "@envelope-zero/ynap-bank2ynab-converter": "1.14.37",
     "@types/iban": "0.0.35",
     "@types/jest": "29.5.7",
     "@types/lodash": "4.14.200",