feat(ynab-parsers): add DKB parser #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekeih
force-pushed
the
add-dkb-parser
branch
from
8bc97d0 to
594ebcd
Compare
morremeyer
requested changes
Dec 28, 2023
morremeyer
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the DKB csv files were supported by the universal bank2ynab parser. But DKB changed a few things that make it impossible to parse their csv files correctly with the bank2ynab parser. Most importantly they started to trim trailing zeros from the inflow/outflow value. This means
100,100,32and1.200,32work but1.200is incorrectly parsed as one euro and 20 cents, because the parser assumes that the first occurrence of.or,from the right is the decimal separator.This PR adds a native parser for the DKB csv files, so we can work around this issue and are also able to adapt the parser for future breaking format changes.