Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RCD for 100% drop_overload case as unconditional_drop_overload #38408

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yanjunxiang-google
Copy link
Contributor

@yanjunxiang-google yanjunxiang-google commented Feb 11, 2025

This is a follow up commit of drop_overload support:#30827.

It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case.

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38408 was opened by yanjunxiang-google.

see: more, trace.

@yanjunxiang-google yanjunxiang-google changed the title Move drop_overload check in router filter to after NoHealthyUpstream … Move drop_overload check in router filter to after NoHealthyUpstream and LoadShed check Feb 11, 2025
@yanjunxiang-google yanjunxiang-google marked this pull request as ready for review February 11, 2025 23:45
@yanjunxiang-google yanjunxiang-google marked this pull request as draft February 11, 2025 23:49
@yanjunxiang-google yanjunxiang-google marked this pull request as ready for review February 11, 2025 23:54
@yanjunxiang-google yanjunxiang-google marked this pull request as draft February 12, 2025 00:29
@yanjunxiang-google yanjunxiang-google changed the title Move drop_overload check in router filter to after NoHealthyUpstream and LoadShed check Set RCD for 100% drop_overload case as unconditional_drop_overload Feb 18, 2025
@yanjunxiang-google
Copy link
Contributor Author

TEST_P(EdsIntegrationTest, DropOverloadTestForEdsClusterAllDrop) { dropOverloadTest(100, "503"); }
tested drop_overload = 100% case.

@yanjunxiang-google yanjunxiang-google marked this pull request as ready for review February 18, 2025 22:25
@yanjunxiang-google
Copy link
Contributor Author

/assign @yanavlasov @yurykats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants