feat(rpc/v06): re-add trivial and unchanged methods #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are trivial and the specs are the same in all JSON-RPC versions, so we can just re-add these to v06.
We used to have a Websocket path for the JSON-RPC 0.6.0 API that allowed access to the same methods via Websockets (no subscriptions).
vbar
approved these changes
Jan 31, 2025
I just use that target because this change would otherwise conflict with that change. Once that PR is merged this will get "re-targeted" to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are trivial and the specs are the same in all JSON-RPC versions, so we can just re-add these to v06.
While adding
pathfinder_getProofI also figured out that we were missing the registration for the v06-specific Websocket route, so I've re-added that.