feat(rpc/v06): re-add block getters #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `starknet_getBlockWithTxHashes` and `starknet_getBlockWithTxs` the only difference compared to v07 is that the block header and pending block header types are missing L1 data gas and L1 DA mode fields. This change also adds some rudimentary tests for testing the serialization of the block header for all the different JSON-RPC versions we're supporting. Closes: #2554
vbar
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
starknet_getBlockWithTxHashesandstarknet_getBlockWithTxsthe only difference compared to v07 is that the block header and pending block header types are missing L1 data gas and L1 DA mode fields.This change also adds some rudimentary tests for testing the serialization of the block header for all the different JSON-RPC versions we're supporting.
Closes: #2554