Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc/v06): re-add write API #2561

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

kkovaacs
Copy link
Contributor

The BROADCASTED_TRANSACTION schema is unchanged between the 0.6.0 and 0.7.1 OpenRPC specification and the write API methods are the same, too.

We can just re-enable starknet_add*Transaction methods with our current implementation.

Closes #2553

The BROADCASTED_TRANSACTION schema is unchanged between the 0.6.0
and 0.7.1 OpenRPC specification and the write API methods are the
same, too.

We can just re-enable `starknet_add*Transaction` methods with our
current implementation.

Closes #2553
@kkovaacs kkovaacs requested a review from a team as a code owner January 31, 2025 14:23
Copy link
Contributor

@vbar vbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; there is actually a fix necessary for add_declare_transaction, but it's included in 740be7a ...

Copy link
Contributor

@t00ts t00ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kkovaacs kkovaacs merged commit 0402ec8 into main Jan 31, 2025
8 checks passed
@kkovaacs kkovaacs deleted the krisztian/rpc-0.6-re-add-write-api branch January 31, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON-RPC 0.6: Tx submit methods
3 participants