JPEG support #39
Closed
JPEG support #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-f sets the format (png, jpeg or both) -j sets jpeq quality
- Optimized former macro functions a fair bit. - Use a struct with id/data to simplify code a lot. - Got rid of uninitialized variables by using the above struct as return value. - Fixed crash bug when trying to shadow the bottom block in a row (access block -1) - Added a few asserts to sanity check function inputs/outputs.
Added new blocks: - carrot crops - potato crops
…rformance analysis
- Simplified some access code that was doing things in over-complex ways or using needless branching. - Moved common early-outs earlier to avoid doing calculations. - Delay doing some calculations until really needed. - Store block data in uint16 internally, instead of doing conversion from source format (mcr/anvil). This takes up 4 bits of wasted space per block but speeds up access. Complexity of access has now been moved to load time, but we access blocks far more often than we load chunks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial implementation of JPEG support as discussed in this Issue.