Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade terraform-provider-equinix to v3.1.1 #245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

euclid-eqx
Copy link
Collaborator

This PR was generated via $ upgrade-provider equinix/pulumi-equinix --kind=provider --target-bridge-version=latest --pr-title-prefix=feat: --java-version=0.16.1.


  • Updating Java Gen version to 0.16.1.
  • Upgrading terraform-provider-equinix from 3.0.0 to 3.1.1.

Copy link

github-actions bot commented Feb 4, 2025

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 14 breaking changes:

Types

  • 🟢 "equinix:fabric/ServiceTokenServiceTokenConnectionASideAccessPointSelectorNetwork:ServiceTokenServiceTokenConnectionASideAccessPointSelectorNetwork": required: "uuid" property has changed to Required
  • 🟢 "equinix:fabric/ServiceTokenServiceTokenConnectionZSideAccessPointSelectorNetwork:ServiceTokenServiceTokenConnectionZSideAccessPointSelectorNetwork": required: "uuid" property has changed to Required
  • "equinix:fabric/getServiceTokenServiceTokenConnectionASideAccessPointSelector:getServiceTokenServiceTokenConnectionASideAccessPointSelector": required:
    • 🟢 "interface" property is no longer Required
    • 🟢 "linkProtocol" property is no longer Required
    • 🟢 "port" property is no longer Required
  • "equinix:fabric/getServiceTokenServiceTokenConnectionZSideAccessPointSelector:getServiceTokenServiceTokenConnectionZSideAccessPointSelector": required:
    • 🟢 "interface" property is no longer Required
    • 🟢 "linkProtocol" property is no longer Required
    • 🟢 "port" property is no longer Required
  • "equinix:fabric/getServiceTokensDataServiceTokenConnectionASideAccessPointSelector:getServiceTokensDataServiceTokenConnectionASideAccessPointSelector": required:
    • 🟢 "interface" property is no longer Required
    • 🟢 "linkProtocol" property is no longer Required
    • 🟢 "port" property is no longer Required
  • "equinix:fabric/getServiceTokensDataServiceTokenConnectionZSideAccessPointSelector:getServiceTokensDataServiceTokenConnectionZSideAccessPointSelector": required:
    • 🟢 "interface" property is no longer Required
    • 🟢 "linkProtocol" property is no longer Required
    • 🟢 "port" property is no longer Required
      No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@ctreatma
Copy link
Contributor

ctreatma commented Feb 5, 2025

This PR has the same problem as #244: some or all of the examples have lost the relaxed version requirement of < 1.0.0 and instead require a specific version (0.20.0).

I'm not exactly sure what's happening here; if I check out this PR and regenerate the examples locally, the relaxed version requirement is restored, but there are also a bunch of other changes (e.g., some example values change from strings to ints).

One thing I notice--though I'm not sure it's impactful here--is that we may not be consistently using the expected version of pulumi everywhere. It looks like CI is just accepting whatever happens to be installed on the machine, but locally there are some make tasks that capture the version of github.com/pulumi/pulumi/pkg/v3 from provider/go.mod and use that one.

As a first pass I suppose we could try, in a separate PR, to ensure that the pulumi version is consistent between CI and local execution, and then re-run the provider upgrade to see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants