Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock endpoint for graphical data format #84

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

eoye
Copy link
Contributor

@eoye eoye commented Feb 5, 2025

Pull requests practices for the SSI team

Aim of the PR

This PR fixes AB#218925.

The aim of this PR is to mock/stub endpoint for getting graphical data format for P&IDs.

Implementation

This has been done by mocking an endpoint for getting the graphical data format for a P&ID by ID, which now return the example json file we have made. An endpoint for getting all P&IDs has also been stubbed.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update

If the changes impact any dependent services then provide details.

How Has This Been Tested?

This has been tested by running the project and testing out the endpoint in swagger.

Additional Changes

I refactored the existing minimal API by splitting it up in it's own folders and files.

@markus-ap
Copy link
Contributor

markus-ap commented Feb 5, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@daghovland daghovland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig bra med refaktorerering, men det var litt vanskelig å se hva som var nytt og hva som var flyttet. Jeg har noen innspill/kommetnarer, men vet ikke om de er riktige (eller viktige)

@eoye eoye merged commit 191641b into main Feb 6, 2025
6 checks passed
@eoye eoye deleted the story/218925-grafical-format-endpoint branch February 17, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants