SVG Resizing #97
Merged
SVG Resizing #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
JohannesETelle
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim of the PR
This PR fixes AB#240703
This PR aims to create a somewhat better user experience when interacting with the SVG.
Implementation
Previously, the SVG container should have updated its size whenever the user resized the window. This did not work as expected and led to some jankiness.
I removed the SVG resizing, because it led to the zoom level resetting every time you resized the window. Now, the SVG expands to fill the available space on mount, and then you change the size by zooming in and out.
The toolbar is also removed, but I kept the "minimap" for now.
Type of change
If the changes impact any dependent services then provide details.
How Has This Been Tested?
Please describe the tests that you ran to verify that your changes works as expected.
Additional Changes