Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization verification on mission schedule #1177

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Add localization verification on mission schedule #1177

merged 4 commits into from
Jan 8, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Nov 14, 2023

No description provided.

@Eddasol Eddasol added feature New feature or request frontend Frontend related functionality labels Nov 14, 2023
@Eddasol Eddasol self-assigned this Nov 14, 2023
@Eddasol Eddasol marked this pull request as draft November 14, 2023 15:10
@Eddasol Eddasol force-pushed the localization-frontend branch 2 times, most recently from b188da0 to 1150958 Compare November 14, 2023 15:12
@Eddasol Eddasol linked an issue Nov 15, 2023 that may be closed by this pull request
Add confirmation of localization before scheduling missions #1095
Closed
@Eddasol Eddasol force-pushed the localization-frontend branch 2 times, most recently from ff5f46a to edbe7fc Compare November 16, 2023 10:00
@aeshub
Copy link
Contributor

aeshub commented Dec 17, 2023

This pull request has automatically been marked as stale as there has been no activity for 30 days.

@aeshub aeshub added the stale This issue or pull request already exists label Dec 17, 2023
@Eddasol Eddasol force-pushed the localization-frontend branch from edbe7fc to 40541c8 Compare January 3, 2024 14:10
@Eddasol Eddasol removed the stale This issue or pull request already exists label Jan 3, 2024
@Eddasol Eddasol force-pushed the localization-frontend branch 7 times, most recently from 79a6d54 to df759b6 Compare January 4, 2024 13:31
@Eddasol Eddasol marked this pull request as ready for review January 4, 2024 13:36
@Eddasol Eddasol force-pushed the localization-frontend branch from df759b6 to 2cbb9fb Compare January 5, 2024 08:31
@Eddasol Eddasol requested a review from andchiind January 5, 2024 12:32
@Eddasol Eddasol force-pushed the localization-frontend branch from 2cbb9fb to 4db8840 Compare January 8, 2024 07:28
aeshub
aeshub approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@aeshub aeshub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have tested it before the weekend but if you want someone to look into the detailed Typescript you should get another review.

@Eddasol Eddasol force-pushed the localization-frontend branch from 4db8840 to d0c0047 Compare January 8, 2024 13:06
UsamaEquinorAFK
UsamaEquinorAFK approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@UsamaEquinorAFK UsamaEquinorAFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aeshub aeshub merged commit 9646abf into equinor:main Jan 8, 2024
@Eddasol Eddasol deleted the localization-frontend branch January 12, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeshub aeshub aeshub approved these changes

@UsamaEquinorAFK UsamaEquinorAFK UsamaEquinorAFK approved these changes

@andchiind andchiind Awaiting requested review from andchiind

Assignees

@Eddasol Eddasol

Labels
feature New feature or request frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add confirmation of localization before scheduling missions
3 participants
@Eddasol @aeshub @UsamaEquinorAFK