Improve blocked alert #1324
Merged
Improve blocked alert #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Eddasol
commented
Jan 9, 2024
•
Eddasol
commented
- Moved to alertContext such that the banner will be updated regardless of viewed paged
- Removed setAlert from dependency in useEffect to fix warning (see linked issue)
- Only call setAlert when blockedRobotNames are changed such that the banner can be dismissed. Will reappear if changes to which robots are blocked or if page is refreshed
- Updated banner to display alternative text if more than on robot is blocked
Eddasol
added
bug
frontend/src/components/Pages/FrontPage/RobotCards/RobotStatusSection.tsx
Show resolved
Hide resolved
UsamaEquinorAFK
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.