Redirect to asset page if no installation selected #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
changed the title
|
Closes #2042 |
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
3 times, most recently
from
1acbaa2 to
1adfbd5
Compare
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
from
1adfbd5 to
a542486
Compare
andchiind
reviewed
Feb 26, 2025
frontend/src/utils/ValidateURL.tsx
Outdated
| import { config } from 'config' | ||
|
|
||
| export function validateURL() { | ||
| const { installationCode, installationName } = useInstallationContext() |
There was a problem hiding this comment.
Does using contexts inside non-component functions not cause an error/warning in the frontend?
There was a problem hiding this comment.
What i got after redirect:
There was a problem hiding this comment.
Could we rename the function so that it's clear that it will navigate away, and not just validate the inspection?
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
from
a542486 to
414b8cc
Compare
mrica-equinor
force-pushed
the
redirect-to-asset-page
branch
from
414b8cc to
3a7a86b
Compare
andchiind
reviewed
Feb 27, 2025
| @@ -15,6 +16,8 @@ const StyledFrontPage = styled.div` | |||
| ` | |||
|
|
|||
| export const FrontPage = () => { | |||
| redirectIfNoInstallationSelected() | |||
There was a problem hiding this comment.
If we wanted to be even more optimal we could useMemo, or a useEffect with empty conditionals here, to prevent this function from needing to be rerun on each render, but it's not too important.
andchiind
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review checklist: