Add managed identity module #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
betaniat
commented
Oct 23, 2024
•
betaniat
commented
- Add manage identity module.
- Assign "Managed identity operator" role to aurora-aks-kubelet-shared.
- Modify access policies in key vault to grant access to MI application.
tsundvoll
reviewed
Oct 23, 2024
tsundvoll
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Great work!
Nice to see the solution and that it was possible to do in one go.
Ideally I would like to see these changes in 3 commits instead of 5, so there is a possibility to take the "Fix typo" commit and the "Add comment azure built-in roles in param files" commit into the "Add principalID for aurora-aks prod and staging" commit. Alternatively squash all of them into one with message "Add managed identity module". You can choose if this is something you think is worth the effort for this time, it is not super important and it works as it stands as well :)
If you are happy with it yourself, feel free to take it in.
Add principalID for aurora-aks prod and staging Fix typo Update key vault access policies with MI Add comment azure built-in roles in param files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.