-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around OTP-21 deprecation of get_stacktrace() and other incompatible changes #1773
Conversation
To discuss: should we just remove the stacktraces where we can afford it rather than duplicating all of that code? |
I published erlware common 1.1.0. |
dc09c78
to
d66a0b2
Compare
So the change in rebar3.erl actually breaks the entire stacktrace/crashdump reporting for uncaught errors. So that needs more work. |
Well shit. I thought we must translate an exception to an error tuple somewhere that we could add a match on stacktrace and add it to the tuple, but not seeing where that was done. Will look more tomorrow. |
Oh, you got it, nevermind :) |
Yeah. Right now I'm checking stuff and I blew up Dialyzer by probably fat-fingering something. I need some better QA on this. |
Alright, I fixed Dialyzer, but rebar3 shell is now tricky because the We would have a regression on #1158 |
I manually confirmed that the new logger has no hangup with the group leaders of before, so I rewrote the thing to avoid some problems. Dialyzer will keep complaining about it but for now that seems good enough. |
So, OTP 20 had a warning preventing the usage of get_stacktrace() outside of a try .. catch expression. Not sure why it ever passed before, but now the code no longer compiles only on that version in rebar3.erl. Will need to dig some more. |
3f5076c
to
9eb0c55
Compare
Reworked the pull request based off the macros by @okeuday at erlang/otp#1783 (comment) -- I also reordered and squashed commits so they work better in the right order. |
9eb0c55
to
e321ca6
Compare
Depends on erlware/erlware_commons#130 to succeed
Fixes #1772