Fix creating a interval=0 throttle together with a test

esl · Nov 26, 2024 · 2176208 · 2176208
1 parent 6ff0b1c
commit 2176208
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/throttle/amoc_throttle_controller.erl b/src/throttle/amoc_throttle_controller.erl
@@ -345,7 +345,7 @@ pool_config(0, _) ->
     Config = #{max_n => 0, delay => infinity, status => active, pid => undefined},
     maps:from_keys(lists:seq(1, no_of_processes()), Config);
 pool_config(Rate, 0) ->
-    Config = #{max_n => Rate, delay => infinity, status => inactive, pid => undefined},
+    Config = #{max_n => Rate, delay => 0, status => inactive, pid => undefined},
     PoolConfig = #{1 := First} = maps:from_keys(lists:seq(1, no_of_processes()), Config),
     PoolConfig#{1 := First#{status => active}};
 pool_config(Rate, Interval) ->

diff --git a/test/throttle_SUITE.erl b/test/throttle_SUITE.erl
@@ -153,7 +153,9 @@ interval_equal_zero_limits_parallelism(_) ->
     E1 = #{rate => 36, interval => 0},
     ?assertMatch({ok, started}, amoc_throttle:start(?FUNCTION_NAME, E1)),
     #{pool_config := Config0} = get_throttle_info(?FUNCTION_NAME),
-    ?assertEqual(1, map_size(maps:filter(fun(_, #{status := S}) -> S =:= active end, Config0))).
+    ActiveWorkers = maps:filter(fun(_, #{status := S}) -> S =:= active end, Config0),
+    ?assertEqual(1, map_size(ActiveWorkers)),
+    ?assertMatch([#{max_n := 36, delay := 0}], maps:values(ActiveWorkers)).
 
 change_rate_to_interval_zero_limits_parallelism(_) ->
     ?assertMatch({ok, started}, amoc_throttle:start(?FUNCTION_NAME, 100)),