fix: Add npm version and fix app setup #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
LGTM, though I think we tried before to specify npm in package.json and it didn't work (4a5cccd) but maybe it will work this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
package.jsonfile and significant refactoring of thesrc/app.jsfile to streamline the code and improve maintainability. The most important changes include adding a new engine requirement, removing unused imports and environment variable checks, and refactoring the plugin loading mechanism.For some reason, Dokku was downgrading npm to v5.x when it saw
package-lock.json, so hardcoding that inpackage.jsonis necessary. The rest is just cleanup using the new Probot APIs.Updates to dependencies:
package.json: Added a new engine requirement fornpmversion 10.x.Refactoring:
src/app.js: Removed unused imports and unnecessary environment variable checks.src/app.js: Refactored the plugin loading mechanism to use a newappFnfunction that assigns plugins to the Probot instance.