-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/calculate performance #13
base: main
Are you sure you want to change the base?
Feature/calculate performance #13
Conversation
jordicenzano
commented
Jan 17, 2021
- Added performance meter
- Fixed cross channel interference (example: try to measure just L channel)
Hi @jordicenzano ! Your addition last week of the true-peak metering option inspired me to do some maintenance and refactoring :) I split things apart into separate files and also removed reliance on global variables that was preventing multiple meters from displaying on the same page. Hopefully you agree that this is easier to read and reason about now? Unfortunately that means this PR would have to be reworked to fit into the new code structure. I want to make sure I understand the nature of the cross-channel bug, though. Should Also, do you happen to know if there are any test fixtures for the ITU-R BS.1770 algorithm? I think it would be great if we could have some unit tests that say "given the following buffer, we expect |
Correct!
Happy to do it!
Just today I added a test file and added to my fork of the repo, see link |