-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sympy potential #5019
Sympy potential #5019
Conversation
Thanks, Lukas. Plesae address the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Don't forget to add the test to the CMake build system and to install and run the linters on your workstation. Here are the relevant sections in the developer guide:
Linter and code formatter, Python integration tests.
Looks good. Just 2 things:
|
@jngrad could you pls take a look? I am not sure, what the linter wants. |
Co-authored-by: Jean-Noël Grad <[email protected]>
Description of changes: