-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new design for FileContributors #14898
base: dev
Are you sure you want to change the base?
feat: use new design for FileContributors #14898
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @konopkja, could you take a look at this? Let me know if anything needs improvement! |
@konopkja Sure, I'll work on this soon! |
Hey @konopkja , I’ve adjusted the gap and made the updates for mobile. I also want to point out a few additional changes I made that you might not notice:
Could you take a look at those as well and let me know if everything looks fine? Appreciate your feedback! |
Hey @JoeChenJ it looks perfect! Really appreciate this particular contribution <3 |
shall we discuss extending this component to other pages outside developer docs or would it be better tackled in another PR? |
I think it would be best to merge this PR first, and then we can extend it in another one, as it might take a bit more time |
Description
Use new design for
FileContributors
Related Issue
#8024