[ShadCN]: Move Color Stories to Tailwind #14915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
reviewed
Feb 17, 2025
.storybook/main.ts
Outdated
| @@ -17,8 +17,9 @@ import type { StorybookConfig } from "@storybook/nextjs" | |||
| const config: StorybookConfig = { | |||
| stories: [ | |||
| "../src/components/**/*.stories.{ts,tsx}", | |||
| "../src/@chakra-ui/stories/*.stories.tsx", | |||
| // "../src/@chakra-ui/stories/*.stories.tsx", | |||
There was a problem hiding this comment.
is there a reason why you left it commented?
| * | ||
| * Used to search CSS Variables and retrieve their values. | ||
| * | ||
| * NOTE: Function created with AI assistance |
src/styles/colors.stories.tsx
Outdated
| import { cn } from "@/lib/utils/cn" | ||
|
|
||
| const meta = { | ||
| title: "Design System/ShadCN Colors", |
There was a problem hiding this comment.
Suggested change
| title: "Design System/ShadCN Colors", | |
| title: "Design System / Colors", |
|
@pettinarip should be good to go now! |
pettinarip
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move color stories to Tailwind.
Had to create a function to retrieve the CSS variables via accessing the document, to then apply in rendering colors and labels.