feat: add ethers v6 codemods #4825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, If you have any repos in mind, then, I can test it on them, and can let you know about its performance. |
|
Thanks! This looks super amazing! |
|
Awesome, if you do know any repos, where I can test them, then it would be great. |
|
Hey, I just wanna update, if you want you can also check it on your end, or if you want to provide with some test repos, then I could check and show you the results. |
Skyeenicole
approved these changes
Nov 25, 2024
| @@ -298,6 +348,11 @@ _code: parsing transactions @lang<script> | |||
| // v6 (the tx can optionally include the signature) | |||
| txBytes = Transaction.from(tx).serialized | |||
|
|
|||
| _note: Codemod replaces [[parseTransaction]] and [[serializeTransaction]] with new [[Transaction]] class for parsing and serializing singatures: | |||
There was a problem hiding this comment.
Suggested change
| _note: Codemod replaces [[parseTransaction]] and [[serializeTransaction]] with new [[Transaction]] class for parsing and serializing singatures: | |
| _note: Codemod replaces [[parseTransaction]] and [[serializeTransaction]] with new [[Transaction]] class for parsing and serializing signatures: |
| @@ -427,6 +482,11 @@ _code: commify @lang<script> | |||
|
|
|||
| commify("1234.5"); | |||
|
|
|||
| _note: Codemod refactors various utility methods mentioned above, constants, data manipualtion functions, and transaction handling: | |||
There was a problem hiding this comment.
Suggested change
| _note: Codemod refactors various utility methods mentioned above, constants, data manipualtion functions, and transaction handling: | |
| _note: Codemod refactors various utility methods mentioned above, constants, data manipulation functions, and transaction handling: |
| @@ -278,6 +323,11 @@ _code: signature manipulation | |||
| splitSig = ethers.Signature.from(sigBytes) | |||
| sigBytes = ethers.Signature.from(splitSig).serialized | |||
|
|
|||
| _note: Codemod replaces [[splitSignature]] and [[joinSignature]] with [[ethers.Signature]] class for parsing and serializing singatures: | |||
There was a problem hiding this comment.
Suggested change
| _note: Codemod replaces [[splitSignature]] and [[joinSignature]] with [[ethers.Signature]] class for parsing and serializing singatures: | |
| _note: Codemod replaces [[splitSignature]] and [[joinSignature]] with [[ethers.Signature]] class for parsing and serializing signatures: |
|
|
||
| npx codemod@latest Ethers/6/Migration-Recipe | ||
|
|
||
| This wil run the following codemods from the Ethers Codemod repository: |
There was a problem hiding this comment.
Suggested change
| This wil run the following codemods from the Ethers Codemod repository: | |
| This will run the following codemods from the Ethers Codemod repository: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instructions on using the ethers-v6-codemods.
This codemod automates the process of migrating to v6 of ethers.js
You can test/run the codemod using:
This allows Ethers.js v5 users to easily automate the changes mentioned in the migration guide to Ethers v6 with a one-line command.