Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config UI: vehicle icons from yaml #18647

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Config UI: vehicle icons from yaml #18647

merged 4 commits into from
Feb 7, 2025

Conversation

naltatis
Copy link
Member

@naltatis naltatis commented Feb 6, 2025

fixes #18625

🚌 support vehicle icons for yaml vehicles
🐜 only show "single phase" property on single-phase devices

Bildschirmfoto 2025-02-06 um 23 42 34

@naltatis naltatis added ux User experience/ interface experimental Experimental feature labels Feb 6, 2025
@An-Wi
Copy link

An-Wi commented Feb 7, 2025

Sehe gerade im Screenshot "LimitSoc".
Ist das jetzt pro Fahrzeug spezifisch in der yaml definierbar oder handelt es sich dabei um das vom Fahrzeug via API ausgelesene Limit?

@naltatis
Copy link
Member Author

naltatis commented Feb 7, 2025

Ist das jetzt pro Fahrzeug spezifisch in der yaml definierbar oder handelt es sich dabei um das vom Fahrzeug via API ausgelesene Limit?

Letzteres. Das ist das Fahrzeug-SoC Limit (sofern verfügbar).

Aber korrekt, wir nutzen hier ein anderes Wording als in der Main UI (SoC vs Ladestand, Limit vs. Fahrzeuglimit). Ich hab das mal angepasst.

Bildschirmfoto 2025-02-07 um 09 23 30 Bildschirmfoto 2025-02-07 um 09 23 19

@andig
Copy link
Member

andig commented Feb 7, 2025

LGTM

@Serhii2511

This comment was marked as off-topic.

@naltatis naltatis merged commit 1633e72 into master Feb 7, 2025
6 checks passed
@naltatis naltatis deleted the fix/config_ui_icons branch February 7, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Experimental feature ux User experience/ interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yaml vehicles icon: Anzeige in Konfiguration falsch
4 participants