Loadpoint: fix reentrant locks #18650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18603
/cc @GrimmiMeloni @naltatis Bisher bin ich davon ausgegangen, dass
RLocksreentrant sind. Tatsächlich ist das nicht der Fall wie @GrimmiMeloni dankbarer Weise in #18603 (comment) heraus gefunden hat.Wir müssen daher (leider) sehr vorsichtig sein, welche Funktionen mit Locks aufgerufen werden. Die Strategie hier ist jetzt:
RLocksnur einmalig in den API Funktionen zu nutzen (exportiert, groß geschrieben)RLocksin internen Funktionen (klein geschrieben)Updateverwendet nach Möglichkeit nur noch API FunktionenIch habe hier auf den großen Umbau verzichtet sondern nur punktuell offensichtliche Probleme angefasst. Leider gibt es kein Tooling das uns hier helfen kann.
TODO