fix: enhance infinite loading of chat when logged out - EXO-67681 (#678) #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user is logged out , the popup to force him reconnect does not show up and we have an infinite calls to the server to retrieve user status and his rooms. This commit fixes the check of the user disconnection that was checking cometd status which is wrong as the logout event is already using the cometd channel to dispatch the event to all pages. Besides, when the eXo platform server returns a 403 error for Rest calls, it is sure that the user is logged out, then we send an event to all components of the Chat app to notify and display the login popup.
|
SonarCloud Quality Gate failed.
|
Jihed525
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user is logged out , the popup to force him reconnect does not show up and we have an infinite calls to the server to retrieve user status and his rooms. This commit fixes the check of the user disconnection that was checking cometd status which is wrong as the logout event is already using the cometd channel to dispatch the event to all pages. Besides, when the eXo platform server returns a 403 error for Rest calls, it is sure that the user is logged out, then we send an event to all components of the Chat app to notify and display the login popup.