Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add documents trash management page - EXO-76028 #151

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

sofyenne
Copy link
Member

No description provided.

@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Dec 18, 2024
@sofyenne sofyenne force-pushed the Task/76028 branch 3 times, most recently from eb69806 to 5779074 Compare December 18, 2024 11:28
rdenarie

This comment was marked as duplicate.

Copy link
Member

@rdenarie rdenarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain briefly how the property eXo.env.portal.documentsTrashNavigationEnabled will be used ?
In the task :
Values:
True: I display the new page in the administration menu
False: I don't have the Trash page in the administration menu

But I'm not sure to understand what you want to do

@rdenarie rdenarie dismissed their stale review December 18, 2024 14:11

validated before answering question

@sofyenne
Copy link
Member Author

Can you explain briefly how the property eXo.env.portal.documentsTrashNavigationEnabled will be used ? In the task : Values: True: I display the new page in the administration menu False: I don't have the Trash page in the administration menu

But I'm not sure to understand what you want to do

You know that the page and navigation are added through the XML configuration. Therefore, we can't prevent the navigation from being displayed using a feature flag in the XML configuration. The idea is to use the added property to prevent the navigation from being displayed in the navigation tree component when the property is set to false!

@sofyenne
Copy link
Member Author

@rdenarie Pull request updated!

@sofyenne sofyenne requested a review from rdenarie December 19, 2024 11:31
@sofyenne sofyenne merged commit 345f15a into feature/experience Dec 19, 2024
7 checks passed
@sofyenne sofyenne deleted the Task/76028 branch December 19, 2024 13:02
sofyenne added a commit that referenced this pull request Dec 19, 2024
* feat: Add documents trash management page - EXO-76028

* Remove the use of the feature flag property
sofyenne added a commit that referenced this pull request Dec 20, 2024
* feat: Add documents trash management page - EXO-76028

* Remove the use of the feature flag property
exo-swf pushed a commit that referenced this pull request Dec 24, 2024
* feat: Add documents trash management page - EXO-76028

* Remove the use of the feature flag property
sofyenne added a commit that referenced this pull request Dec 30, 2024
* feat: Add documents trash management page - EXO-76028

* Remove the use of the feature flag property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants