fix: [BUG] - Documents: Folders view filter issue if folder title has Umlaut - EXO-76165 #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Umlaut - EXO-76165 Prior to this fix, Files starting with accented characters, returned by load more are placed among the items retrieved with the first call. This is because this characters are retrieved at the end of the sorted items from the database but in the front side we apply a natural sorting that ensures that accented characters are placed after their non-accented counterparts. This commit fix this by splitting the list of items (accented and not eccented) then sort them separately.
|
Jihed525
approved these changes
Feb 13, 2025
mkrout
added a commit
that referenced
this pull request
Feb 14, 2025
… Umlaut - EXO-76165 (#1338) Prior to this fix, Files starting with accented characters, returned by load more are placed among the items retrieved with the first call. This is because this characters are retrieved at the end of the sorted items from the database but in the front side we apply a natural sorting that ensures that accented characters are placed after their non-accented counterparts. This commit fix this by splitting the list of items (accented and not eccented) then sort them separately.
mkrout
added a commit
that referenced
this pull request
Feb 14, 2025
… Umlaut - EXO-76165 (#1338) (#1339) Prior to this fix, Files starting with accented characters, returned by load more are placed among the items retrieved with the first call. This is because this characters are retrieved at the end of the sorted items from the database but in the front side we apply a natural sorting that ensures that accented characters are placed after their non-accented counterparts. This commit fix this by splitting the list of items (accented and not eccented) then sort them separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, Files starting with accented characters, returned by load more are placed among the items retrieved with the first call. This is because these characters are retrieved at the end of the sorted items from the database but in the front side, we apply a natural sorting that ensures that accented characters are placed directely after their non-accented counterparts.
This commit fixes this by splitting the list of items (accented and not accented) and then sorting them separately.