Updating for Python v3.10 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarmey
commented
Jul 27, 2023
| try: | ||
| from collections import abc | ||
| collections.MutableMapping = abc.MutableMapping | ||
| collections.Iterable = abc.Iterable |
There was a problem hiding this comment.
@borcuttjahns, are these transfers from abc.X to collections.X needed somewhere? I couldn't find a place where they are used.
There was a problem hiding this comment.
Hello, I am having issues running this code and it seams to be localized to this same issue you are talking about here. I was wondering if you found a solution.
There was a problem hiding this comment.
@DavidGorlin this branch should fix the issue. It's what we currently use.
There was a problem hiding this comment.
Or do you mean the code here is erroring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all @borcuttjahns work, but I wanted to open this up so that we can close the fork.