Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag --no-isolate to improve performance #306

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

ariskemper
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 17, 2023

‼️ Deploy request for valibot rejected.

Name Link
🔨 Latest commit 3716a3f

@fabian-hiller fabian-hiller self-assigned this Dec 18, 2023
@fabian-hiller fabian-hiller added the enhancement New feature or request label Dec 18, 2023
@ariskemper ariskemper marked this pull request as ready for review December 23, 2023 11:42
@ariskemper
Copy link
Contributor Author

ariskemper commented Dec 23, 2023

@fabian-hiller maybe we should have another script like test.dev to run it locally with vitest --no-isolate for faster development and in github actions we run it with vitest.

@fabian-hiller
Copy link
Owner

I will give you feedback later.

@fabian-hiller
Copy link
Owner

Is there a reason why you would run it in isolation on GitHub?

@fabian-hiller fabian-hiller merged commit 3c779bc into fabian-hiller:main Dec 23, 2023
6 checks passed
@ariskemper
Copy link
Contributor Author

ariskemper commented Dec 23, 2023

Since Valibot doesn' use global variables we could use it for Github. It would speed up branch pipeline .

@fabian-hiller
Copy link
Owner

Yes, it speeds the process by more than 10x. So thanks a lot for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants