Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies metadata #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

MangelMaxime
Copy link
Member

Hello @ncave,

I was trying to update the metadata dependency and encounter some breaking changes along the way. I was able to fix the change of path for calling the different tools and move to Ionide.ProjInfo instead of DotNet. ProjInfo because the list of DLLs returned was empty and DotNet. ProjInfo is not maintained anymore.

However, when running the script and running fcs-export.fsproj successfully, I only get the .NET standard DLLs exported. Browser.XXX.dll and Fable.Repl.Lib.dll is missing from the output.

Could you please check if something has changed in your fork that we need to update ?

In order, to run ./src/Export/build.sh you need to have your F# compiler fork folder alongside the REPL folder in a folder named fsharp_fable.

.
├── fsharp_fable
├── repl

@ncave
Copy link
Contributor

ncave commented Oct 24, 2024

@MangelMaxime I was waiting for .NET 9.0 to be released officially before we do that, but if you prefer, we can start a bit earlier. Let me know.

@MangelMaxime
Copy link
Member Author

@ncave I am fine with waiting.

Only reason, I thought about updating the REPL metadata was because someone reported a bug for Fable.Browser.Event using the REPL when it was already fixed.

The reason, why the REPL code and his code were wrong was because both are using an old version of the package.

We can keep this PR open, and wait for .NET 9 to be released before updating the metadata 👍

@ncave
Copy link
Contributor

ncave commented Oct 25, 2024

@MangelMaxime Technically you can just drop in the package replacement for Browser.*.dll as it is, it's just bindings so it doesn't need to go through code truncation for size, and it doesn't need to wait for .NET 9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants