Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting launch actions #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix reporting launch actions #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FBControlCore/Reporting/FBEventConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ extern FBEventName const FBEventNameHelp;
extern FBEventName const FBEventNameInstall;
extern FBEventName const FBEventNameKeyboardOverride;
extern FBEventName const FBEventNameLaunch;
extern FBEventName const FBEventNameLaunchAgent;
extern FBEventName const FBEventNameLaunchXCTest;
extern FBEventName const FBEventNameList;
extern FBEventName const FBEventNameListApps;
Expand Down
1 change: 1 addition & 0 deletions FBControlCore/Reporting/FBEventConstants.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
FBEventName const FBEventNameInstall = @"install";
FBEventName const FBEventNameKeyboardOverride = @"keyboard_override";
FBEventName const FBEventNameLaunch = @"launch";
FBEventName const FBEventNameLaunchAgent = @"agentlaunch";
FBEventName const FBEventNameLaunchXCTest = @"launch_xctest";
FBEventName const FBEventNameList = @"list";
FBEventName const FBEventNameListApps = @"list_apps";
Expand Down
6 changes: 3 additions & 3 deletions FBControlCore/Reporting/FBReportingiOSActionReaderDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ - (NSString *)interpretAction:(id<FBiOSTargetFuture>)action eventType:(FBEventTy
FBEventName eventName;
if ([[[action class] futureType] isEqualToString:FBiOSTargetFutureTypeApplicationLaunch]) {
eventName = FBEventNameLaunch;
} else if ([[[action class] futureType] isEqualToString:FBiOSTargetFutureTypeApplicationLaunch]) {
eventName = FBEventNameLaunch;
}else if ([[[action class] futureType] isEqualToString:FBiOSTargetFutureTypeApplicationLaunch]) {
} else if ([[[action class] futureType] isEqualToString:FBiOSTargetFutureTypeAgentLaunch]) {
eventName = FBEventNameLaunchAgent;
} else if ([[[action class] futureType] isEqualToString:FBiOSTargetFutureTypeTestLaunch]) {
eventName = FBEventNameLaunchXCTest;
} else {
eventName = [[action class] futureType];
Expand Down