igl | opengl | The glUniformBlockBinding() function only needs to be called once for each program #190
Conversation
…ach program and does not need to be called every frame.
There was a problem hiding this comment.
There is an non-const
std::unordered_map<int, size_t>& uniformBlockBindingMap();
method exposed in RenderPipelineState, which makes this change not super-safe. However, it doesn't look like that method is used anywhere, so if you also remove that method in this PR, this is more ore less OK.
But also, just wanted to understand your motivation for making this change -- do you see any bugs/perf-issues caused by setting uniform block binding points multiple times?
|
Calling multiple times does not cause any functional issues, but according to the relevant documentation, calling it once is sufficient. |
|
@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
The glUniformBlockBinding() function only needs to be called once for each program and does not need to be called every frame.