Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement incremental resolution: Fast Refresh on new files, changed symlinks, etc. #1161

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

robhogan
Copy link
Contributor

@robhogan robhogan commented Dec 25, 2023

  • Fast Refresh: correctly reflect when filesystem changes should result in different resolutions - eg creating a more specific platform variant, installing a more local node_modules, symlinks added or traversed symlinks deleted.
  • Unblock resolution caching.

Differential Revision: D52391695

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 25, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52391695

@robhogan robhogan marked this pull request as draft December 25, 2023 15:07
robhogan added a commit to robhogan/metro that referenced this pull request Dec 25, 2023
…changes (facebook#1161)

Summary: Pull Request resolved: facebook#1161

Differential Revision: D52391695
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52391695

robhogan and others added 9 commits January 5, 2024 05:32
Differential Revision: D52464135

fbshipit-source-id: ed36dd08bca6eea5195d4ff04785538b72ea4e3d
Differential Revision: D52480112

fbshipit-source-id: 49bde6a7ac45487d91abdafc3a003ccf11b9766f
Differential Revision: D52513808

fbshipit-source-id: a88814ae7535451ad43974ba3f6b9d174909f1e7
Differential Revision: https://internalfb.com/D52255863

fbshipit-source-id: 727474fd223c7ee76d9b5111718e0d6755fb96a6
…ith lookup (allow additional information)

Differential Revision: https://internalfb.com/D52390401

fbshipit-source-id: 6e8a51d40c72f750fb9c1292c70b9006a0cec08f
…esults

Differential Revision: D52391404

fbshipit-source-id: b9dd8f96d72487aa2d8a6784569c30553e3b5af4
Differential Revision: D52541664

fbshipit-source-id: 526c06e664d2b8c258f2e47a772b3553c339d58d
Differential Revision: D52391578

fbshipit-source-id: 3b01b373651bb69e0b43d238b067be9889e4187d
…changes (facebook#1161)

Summary: Pull Request resolved: facebook#1161

Differential Revision: D52391695

fbshipit-source-id: a7b33def0036bf0ad59cc0256e36a12862fcffa1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52391695

@robhogan robhogan changed the title Pass resolution dependencies through to Graph, invalidate modules on changes Implement incremental resolution: Fast Refresh on new files, changed symlinks, etc. Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants