This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Added mapillary overlay to task selection map #280
Open
ezzhang8
wants to merge
26
commits into
facebookarchive:develop
Choose a base branch
from
MLH-Fellowship:mapillaryoverlay
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added mapillary overlay to task selection map #280
ezzhang8
wants to merge
26
commits into
facebookarchive:develop
from
MLH-Fellowship:mapillaryoverlay
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Date picker added to imagery page in settings - Database migrated with new column for the date
2 new trim toggles + image capture on legend
- Mapillary photo overlay now open by default in iD editor - fromDate filter set from project settings in iD editor
- Added image capture mode toggle - Settings related to image capture mode only appear if this toggle is enabled - Added all connected UI prompts to messages - "Earliest imagery capture date" shortened to "After:" positioned before date picker - Added mapillary organization id filter input
added earliestStreetImagery as a dependency, wrapped filter in if statement
Updates DTOs to make the new project settings persistent
Now updates based on whether user selects image capture mode
Now only enables mapillary and date filter by default if image capture mode is enabled
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 4, 2022
Fixed missing brackets
Renamed new columns to use underscores Project states
@ezzhang8 can you rebase this PR onto your other one please. There is a bunch of duplicate changes and rebasing will save me a time and make sure I don't make duplicate comments |
ezzhang8
force-pushed
the
mapillaryoverlay
branch
from
August 8, 2022 22:10
e1cac4a
to
c4b94ed
Compare
@zlavergne Rebased this branch onto the other PR :) |
zlavergne
suggested changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main thing is regarding using an already built switch component for the Mapillary layers and hooking it up with a state.
Co-authored-by: Zack LaVergne <[email protected]>
@zlavergne Addressed all the comments. Let me know if there something I missed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Component: Backend
Component: Frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.