Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

[WIP] convert html5-entities like , #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timjacobi
Copy link
Contributor

@timjacobi timjacobi commented Mar 29, 2018

I'm looking to fix https://github.com/Automattic/facebook-instant-articles-wp/issues/881
There are a couple of tests failing which makes me wonder

  • Why do these tests expect entities not to be converted to their characters?
  • What should the output be to IA, entities (&period ;) or their characters (.)?
  • "some fragments are written as html entities even after transformed so normalize all strings to html entities and compare them." in the tests worries me. Should we not try to convert all entities?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Junk characters like , in Instant Article feed
2 participants