Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 404 links and spelling #2505

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

polytur
Copy link

@polytur polytur commented Jan 28, 2025

Why is this change needed?

Hi! This pull request addresses several broken links in the documentation, which have been removed. Additionally, a typo untill has been corrected to until. Removing the broken links improves the accessibility and functionality of the documentation.

Merge Checklist


PR-Codex overview

This PR focuses on correcting the documentation and migration comments related to the handling of the fid index for fname messages, as well as improving the clarity of type references in documentation files.

Detailed summary

  • Updated comment in 11.fnameIndex.ts to correct "Up untill" to "Up until".
  • Changed type references from markdown links to plain text in:
    • EthersEip712Signer.md
    • EthersV5Eip712Signer.md
    • ViemLocalEip712Signer.md
  • Added a newline at the end of README.md in the hello-world example.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: f74527b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 5:32pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant